Open
Conversation
…ultipleListsPredicates,multipleListsPredicatesWithDocument in ListRule.kt and ListRuleBuilder.kt
Darderion
requested changes
Oct 28, 2022
| val hardConfigurationWords: MutableList<String> = mutableListOf() | ||
| File(fileConfigurationWordsName).forEachLine { hardConfigurationWords.add(it) } | ||
|
|
||
| lines.forEach { line -> line.text.forEach { |
Owner
There was a problem hiding this comment.
It is preferred to use functional approach
Suggestion: use map, filter and reduce instead of for loop
| } | ||
| } | ||
|
|
||
| if (wordCount < precisionWordCount) |
Owner
There was a problem hiding this comment.
It is preferred to use explicit return statements
| if (word!="Заключение") | ||
| linesIndexes.first <= it.documentIndex && it.documentIndex < linesIndexes.second | ||
| else linesIndexes.first <= it.documentIndex | ||
| }.toMutableList() |
Owner
There was a problem hiding this comment.
It is preferred to use "toList" if list isn't supposed to be modified
| linesFilters.forEach { lines = it(lines, document) } | ||
|
|
||
| if (lines.isNotEmpty()) { | ||
| singleLinePredicates.forEach { predicate -> |
Owner
There was a problem hiding this comment.
It is preferred to use a single add method by using functional approach with map, reduce, filter and flatten instead of forEach
| type, | ||
| region, | ||
| name) | ||
| } No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.